Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overload w.r.t. fallback parameter to configparser.SectionProxy.get #12935

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

brianschubert
Copy link
Contributor

Fixes #12919

The return type of RawConfigParser.get was overloaded w.r.t. the fallback parameter in #2406. This PR updates SectionProxy.get to match.

Also did some driveby updates of T | Any to T | MaybeNone where applicable.

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 0311438 into python:main Nov 25, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configparser.SectionProxy.get(...) doesn't recognise bool as a valid type for argument 2
2 participants